On 9/5/22 12:04, Richard Henderson wrote:
On 9/5/22 10:55, Milica Lazarevic wrote:
Two class fields have been deleted.
Since the m_requested_instruction_categories field always has the same
value, which is ALL_ATTRIBUTES, the only use of that field has been
replaced with the concrete ALL_ATTRIBUTES value.
Since these ALL_ATTRIBUTES tests are always true, you could just remove them.
The second class field m_pc is added as a parameter where needed.
Therefore, prototypes of the following functions have been changed:
- public NMD::Disassemble method
- private NMD::Disassemble method
- NMD::ADDRESS method
- all of the disassembly_function methods
Accordingly, the disassembly_function typedef has been changed.
Actually, you might as well introduce
struct Dis_info {
uint64_t m_pc;
};
now, so that you don't have to replace all of this parameter again in patch 15.
r~
