On Thu, Sep 15, 2022 at 10:43:15PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step. This is the step for qapi/ui.json. > > Said commit explains the transformation in more detail. The invariant > violations mentioned there do not occur here. > > Cc: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > monitor/hmp-cmds.c | 12 ++++-------- > ui/console.c | 4 ++-- > ui/input.c | 4 ++-- > ui/spice-core.c | 5 ----- > ui/vnc.c | 10 ---------- > scripts/qapi/schema.py | 1 - > 6 files changed, 8 insertions(+), 28 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
