Hi Stefan, On Wed, Sep 21, 2022 at 8:24 PM Thomas Huth <th...@redhat.com> wrote: > > On 21/09/2022 14.18, Bin Meng wrote: > > Hi, > > > > On Thu, Sep 8, 2022 at 9:28 PM Bin Meng <bmeng...@gmail.com> wrote: > >> > >> At present packaging the required DLLs of QEMU executables is a > >> manual process, and error prone. > >> > >> Improve scripts/nsis.py by adding a logic to automatically package > >> required DLLs of QEMU executables. > >> > >> 'make installer' is tested in the cross-build on Linux in CI, but > >> not in the Windows native build. Update CI to test the installer > >> generation on Windows too. > >> > >> During testing a 32-bit build issue was exposed in block/nfs.c and > >> the fix is included in this series. > >> > >> > >> Bin Meng (7): > >> scripts/nsis.py: Drop the unnecessary path separator > >> scripts/nsis.py: Fix destination directory name when invoked on > >> Windows > >> scripts/nsis.py: Automatically package required DLLs of QEMU > >> executables > >> .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build > >> block/nfs: Fix 32-bit Windows build > >> .gitlab-ci.d/windows.yml: Unify the prerequisite packages > >> .gitlab-ci.d/windows.yml: Test 'make installer' in the CI > >> > >> meson.build | 1 + > >> block/nfs.c | 8 ++++++ > >> .gitlab-ci.d/windows.yml | 40 ++++++++++++++++++++------- > >> scripts/nsis.py | 60 +++++++++++++++++++++++++++++++++------- > >> 4 files changed, 89 insertions(+), 20 deletions(-) > >> > > > > I see Thomas only queued patch #4 (".gitlab-ci.d/windows.yml: Drop the > > sed processing in the 64-bit build") > > > > What about other patches? > > I hope that Stefan Weil (our W32 maintainer) could have a look at these > first...
Would you please comment this series? Thanks! Regards, Bin