On Thu, Sep 22, 2022 at 6:12 PM Tommy Wu <tommy...@sifive.com> wrote: > > To the maintainers: > > Thank Alistair and Jim for the review. > Bernhard Beschow sent the same patch : > https://lists.gnu.org/archive/html/qemu-riscv/2022-09/msg00126.html > > It seems that this simple patch is helpful. Could you help us to merge this > patch? > Thanks for your great help!
Hey Tommy, Sorry for the mixup! This patch fell through the cracks after I had reviewed it. I just applied the other patch as I had already run it through my testing before I saw this. This is my fault, I'm sorry your patch didn't get applied. For next time, feel free to ping your patch if it hasn't had any movement in a week. That helps ensure I don't miss anything Alistair > > Regards, > Tommy Wu > > > > On Mon, Aug 22, 2022 at 11:33 AM Alistair Francis <alistai...@gmail.com> > wrote: >> >> On Fri, Aug 19, 2022 at 5:12 PM Tommy Wu <tommy...@sifive.com> wrote: >> > >> > Fix the type of parent_obj of SiFiveEState from 'SysBusDevice' >> > to 'MachineState'. Because the parent of SiFiveEState is 'MachineState'. >> > >> > Signed-off-by: Tommy Wu <tommy...@sifive.com> >> >> Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> >> >> Alistair >> >> > --- >> > include/hw/riscv/sifive_e.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/include/hw/riscv/sifive_e.h b/include/hw/riscv/sifive_e.h >> > index 83604da805..24359f9fe5 100644 >> > --- a/include/hw/riscv/sifive_e.h >> > +++ b/include/hw/riscv/sifive_e.h >> > @@ -41,7 +41,7 @@ typedef struct SiFiveESoCState { >> > >> > typedef struct SiFiveEState { >> > /*< private >*/ >> > - SysBusDevice parent_obj; >> > + MachineState parent_obj; >> > >> > /*< public >*/ >> > SiFiveESoCState soc; >> > -- >> > 2.27.0 >> > >> >