On Wed, Sep 28, 2022 at 5:43 PM Thomas Huth <th...@redhat.com> wrote: > > On 27/09/2022 13.06, Bin Meng wrote: > > From: Bin Meng <bin.m...@windriver.com> > > > > At present the codes uses sigaction() to install signal handler with > > a flag SA_RESETHAND. Such usage can be covered by the signal() API > > that is a simplified interface to the general sigaction() facility. > > > > Update to use signal() to install the signal handler, as it is > > available on Windows which we are going to support. > > > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > > > (no changes since v1) > > > > tests/qtest/libqtest.c | 14 +++----------- > > 1 file changed, 3 insertions(+), 11 deletions(-) > > > > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > > index 269d622fe3..f0ac467903 100644 > > --- a/tests/qtest/libqtest.c > > +++ b/tests/qtest/libqtest.c > > @@ -66,7 +66,7 @@ struct QTestState > > }; > > > > static GHookList abrt_hooks; > > -static struct sigaction sigact_old; > > +static sighandler_t sighandler_old; > > This seems to break compilation on NetBSD (which you can test via "make > vm-build-netbsd" on a Linux KVM host):
Oops, so this means this test is not covered by GitLab CI ... > > > ../src/tests/qtest/libqtest.c:86:8: error: unknown type name 'sighandler_t' > static sighandler_t sighandler_old; > ^~~~~~~~~~~~ > Regards, Bin
