> On Aug 29, 2022, at 8:40 AM, Thomas Huth <th...@redhat.com> wrote: > > On 07/08/2022 12.39, John Levon wrote: >> On Fri, Aug 05, 2022 at 09:24:56AM +0100, Daniel P. Berrangé wrote: > [...] >>> If we do add something as a submodule for some reason, I'd like us to >>> say upfront that this is for a fixed time period (ie maximum of 3 >>> releases aka 1 year) only after which we'll remove it no matter what. >> I'm not clear on the costs of having the submodule: could you please explain >> why >> it's an issue exactly? > > Some reasoning can be found here: > > https://lore.kernel.org/qemu-devel/d7a7b28f-a665-2567-0fb6-e31e7ecbb...@redhat.com/ > >> I can only think of the flaky test issue (for which I'm >> sorry). > > Speaking of that test issue, yes, it would be good to get this patch included > now as soon as the 7.1 release has been done. Who's going to send a pull > request for this?
Now that QEMU 7.1 has released, could we please pull this patch in - just so no one else has a bad experience when testing? -- Jag > > Thomas >