Peter Maydell <peter.mayd...@linaro.org> writes:
> On Tue, 18 Oct 2022 at 10:21, Alex Bennée <alex.ben...@linaro.org> wrote: >> >> >> Jiri Slaby <jirisl...@kernel.org> writes: >> >> > On 17. 10. 22, 16:13, Peter Maydell wrote: >> >> * for situations where the guest has misprogrammed the device, >> >> log that with qemu_log_mask(LOG_GUEST_ERROR, ...) >> >> and continue with whatever the real hardware would do, or >> >> some reasonable choice if the h/w spec is vague >> > >> > As I wrote in the previous mail, can we stop the machine after the >> > print somehow, for example? So that the students have to "cont" in the >> > qemu console as an acknowledgment when this happens. >> >> You can bring the system to a halt with vm_stop(RUN_STATE_PAUSED) or >> possible RUN_STATE_DEBUG? > > No, please don't do anything like that. This should not be special. > Just log a message if the guest does something bad. There are > an absolute ton of things that the guest can do wrong, and > in general QEMU does not attempt to be an "identify all the > ways the guest does something wrong in a friendly way" system. We should clean-up the other uses of vm_stop in hw/ then: ./hw/ppc/prep_systemio.c:78: vm_stop(RUN_STATE_PAUSED); ./hw/ppc/vof.c:921: vm_stop(RUN_STATE_PAUSED); ./hw/vfio/pci.c:2725: vm_stop(RUN_STATE_INTERNAL_ERROR); > > thanks > -- PMM -- Alex Bennée
