Re: [PATCH v12 12/17] net: dgram: add unix socket

[Philippe Mathieu-Daudé]

On 20/10/22 11:16, Laurent Vivier wrote:

Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Stefano Brivio <sbri...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <m...@redhat.com>
QAPI schema
Acked-by: Markus Armbruster <arm...@redhat.com>

Eventually:

  Acked-by: Markus Armbruster <arm...@redhat.com> (QAPI schema)

---
  net/dgram.c     | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
  qapi/net.json   |  2 +-
  qemu-options.hx |  1 +
  3 files changed, 55 insertions(+), 2 deletions(-)

diff --git a/net/dgram.c b/net/dgram.c
index e581cc62f39f..02a189e36358 100644
--- a/net/dgram.c
+++ b/net/dgram.c
@@ -426,6 +426,7 @@ int net_init_dgram(const Netdev *netdev, const char *name,
      SocketAddress *remote, *local;
      struct sockaddr *dest_addr;
      struct sockaddr_in laddr_in, raddr_in;
+    struct sockaddr_un laddr_un, raddr_un;
      socklen_t dest_len;

assert(netdev->type == NET_CLIENT_DRIVER_DGRAM);

@@ -465,7 +466,7 @@ int net_init_dgram(const Netdev *netdev, const char *name,
          }
      } else {
          if (local->type != SOCKET_ADDRESS_TYPE_FD) {
-            error_setg(errp, "type=inet requires remote parameter");
+            error_setg(errp, "type=inet or unix require remote parameter");

Maybe clearer reworded as:

  "type=inet or type=unix requires remote parameter"

              return -1;
          }
      }