On Fri, Oct 21, 2022 at 05:15:32PM +1000, Richard Henderson wrote:
> Change 32-bit tci TCG_TARGET_CALL_ARG_I32 to TCG_CALL_ARG_EVEN, to
> force 32-bit values to be aligned to 64-bit.  With a small reorg
> to the argument processing loop, this neatly replaces an ifdef for
> CONFIG_TCG_INTERPRETER.
> 
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
>  tcg/tci/tcg-target.h |  3 ++-
>  tcg/tcg.c            | 62 ++++++++++++++++++++++++++------------------
>  2 files changed, 39 insertions(+), 26 deletions(-)

Hi,

This patch breaks s390x-on-s390x emulation:

    s390x$ ./configure --target-list=s390x-linux-user
    s390x$ make -j$(nproc)
    s390x$ make check-tcg
    ...
    TEST    convd on s390x
    ERROR:../tcg/tcg.c:1575:tcg_gen_callN: code should not be reached
 
With the next patch ("tcg: Reorg function calls") the failure is
slightly different:

    TEST    convd on s390x
    timeout: the monitored command dumped core

s390x-on-x86_64 works though.

Best regards,
Ilya

Reply via email to