On Thu, 2022-12-01 at 22:08 +0800, Bin Meng wrote: > "hartid-base" and "priority-base" are zero by default. There is no > need to initialize them to zero again. > > Signed-off-by: Bin Meng <bm...@tinylab.org> > --- > > hw/riscv/opentitan.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Wilfred Mallawa <wilfred.mall...@wdc.com> > > diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c > index be7ff1eea0..da73aa51f5 100644 > --- a/hw/riscv/opentitan.c > +++ b/hw/riscv/opentitan.c > @@ -165,10 +165,8 @@ static void lowrisc_ibex_soc_realize(DeviceState > *dev_soc, Error **errp) > > /* PLIC */ > qdev_prop_set_string(DEVICE(&s->plic), "hart-config", "M"); > - qdev_prop_set_uint32(DEVICE(&s->plic), "hartid-base", 0); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-sources", 180); > qdev_prop_set_uint32(DEVICE(&s->plic), "num-priorities", 3); > - qdev_prop_set_uint32(DEVICE(&s->plic), "priority-base", 0x00); > qdev_prop_set_uint32(DEVICE(&s->plic), "pending-base", 0x1000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-base", 0x2000); > qdev_prop_set_uint32(DEVICE(&s->plic), "enable-stride", 32);
- [PATCH 01/15] hw/riscv: Select MSI_NONBROKEN in SIFIVE_PL... Bin Meng
- [PATCH 15/15] hw/intc: sifive_plic: Fix the pending ... Bin Meng
- Re: [PATCH 15/15] hw/intc: sifive_plic: Fix the ... Wilfred Mallawa
- Re: [PATCH 15/15] hw/intc: sifive_plic: Fix ... Bin Meng
- Re: [PATCH 15/15] hw/intc: sifive_plic: ... Wilfred Mallawa
- Re: [PATCH 15/15] hw/intc: sifive_plic: Fix the ... Alistair Francis
- [PATCH 14/15] hw/riscv: opentitan: Drop "hartid... Bin Meng
- Re: [PATCH 14/15] hw/riscv: opentitan: Drop &quo... Wilfred Mallawa
- Re: [PATCH 14/15] hw/riscv: opentitan: Drop &quo... Alistair Francis
- [PATCH 09/15] hw/riscv: microchip_pfsoc: Fix the num... Bin Meng
- Re: [PATCH 09/15] hw/riscv: microchip_pfsoc: Fix... Wilfred Mallawa
- Re: [PATCH 09/15] hw/riscv: microchip_pfsoc: Fix... Alistair Francis
- Re: [PATCH 09/15] hw/riscv: microchip_pfsoc: Fix... Conor Dooley
- [PATCH 08/15] hw/intc: sifive_plic: Update "num... Bin Meng
- Re: [PATCH 08/15] hw/intc: sifive_plic: Update &... Alistair Francis
- [PATCH 12/15] hw/riscv: virt: Fix the value of "... Bin Meng
- Re: [PATCH 12/15] hw/riscv: virt: Fix the value ... Alistair Francis