On Mon, 2022-12-05 at 23:13 +0100, Philippe Mathieu-Daudé wrote:
> > +static int kvm_xen_hcall_hvm_op(struct kvm_xen_exit *exit,
> > + int cmd, uint64_t arg)
> > +{
> > + switch (cmd) {
> > + case HVMOP_pagetable_dying: {
> > + exit->u.hcall.result = -ENOSYS;
> > + return 0;
> > + }
> > + }
>
> Could it be helpful to have a trace event here, or log a GUEST_ERROR?
>
> > + exit->u.hcall.result = -ENOSYS;
> > + return HCALL_ERR;We already have a trace event for hypercalls. So the unimplemented ones look something like this (e.g. failing to set FIFO event channels, then failing to get the CONSOLE_EVTCHN HVM param)... [ 0.151084] NR_IRQS: 524544, nr_irqs: 256, preallocated irqs: 16 kvm_xen_hypercall xen_hypercall: cpu 0 cpl 0 input 32 a0 0xb a1 0xffffffffbda03da0 a2 0xffff93cc3ec2e9a0 ret 0xffffffffffffffda [ 0.152018] xen:events: Using 2-level ABI kvm_xen_hypercall xen_hypercall: cpu 0 cpl 0 input 34 a0 0x0 a1 0xffffffffbda03dd8 a2 0x7ff0 ret 0x0 [ 0.152731] xen:events: Xen HVM callback vector for event delivery is enabled [ 0.154158] rcu: srcu_init: Setting srcu_struct sizes based on contention. [ 0.170239] Console: colour VGA+ 80x25 kvm_xen_hypercall xen_hypercall: cpu 0 cpl 0 input 34 a0 0x1 a1 0xffffffffbda03e60 a2 0x7ff0 ret 0xffffffffffffffda [ 0.170966] Cannot get hvm parameter CONSOLE_EVTCHN (18): -38! (I just fixed a PRIu64 to PRIx64 in the trace event definition)
smime.p7s
Description: S/MIME cryptographic signature
