Hi Andrey, Unfortunately, I can't merge your patch as is. There are several OS officially supported by QEMU that have GLib2 < 2.73.2 For example, we support Fedora 35 (GLib2 = 2.69.2) for cross-compilation and we run CI tests on Fedora 35.
Also, currently, QEMU support GLib2 2.56 ( https://github.com/qemu/qemu/blob/ea3a008d2d9ced9c4f93871c823baee237047f93/configure#L1466 ) So, the build process should check the GLib2 version and select libpcre2 or libpcre. Best Regards, Konstantin Kostiuk. On Mon, Dec 12, 2022 at 2:23 PM Andrey Drobyshev < andrey.drobys...@virtuozzo.com> wrote: > On 11/28/22 15:02, Andrey Drobyshev wrote: > > According to GLib changelog [1], since version 2.73.2 GLib is using > > libpcre2 instead of libpcre. As a result, qemu-ga MSI installation > > fails due to missing DLL. > > > > This commit makes wixl to put libpcre2-8-0.dll into the MSI bundle. > > > > [1] https://gitlab.gnome.org/GNOME/glib/-/releases#2.73.2 > > > > Signed-off-by: Andrey Drobyshev <andrey.drobys...@virtuozzo.com> > > --- > > qga/installer/qemu-ga.wxs | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > [...] > > Ping > >
