Am 16/12/2022 um 17:12 schrieb Vladimir Sementsov-Ogievskiy: > On 12/13/22 11:53, Kevin Wolf wrote: >> --- a/include/block/block_int-common.h >> +++ b/include/block/block_int-common.h >> @@ -729,7 +729,7 @@ struct BlockDriver { >> void (*bdrv_debug_event)(BlockDriverState *bs, BlkdebugEvent >> event); >> /* io queue for linux-aio */ >> - void (*bdrv_io_plug)(BlockDriverState *bs); >> + void coroutine_fn (*bdrv_io_plug)(BlockDriverState *bs); > > But you didn't add coroutine_fn to realizations of this callback. Seems, > it should be done > This has to be done by Paolo & Alberto Faria work to add missing coroutine_fn and various annotations in a systematic way. It has to be done using tools like vrc, and not manually because it's not feasible. Not covered by this serie. Thank you, Emanuele
- [PATCH 03/14] block: Convert bdrv_io_unplug()... Kevin Wolf
- [PATCH 09/14] block: Convert bdrv_get_info() ... Kevin Wolf
- [PATCH 04/14] block: Rename refresh_total_sec... Kevin Wolf
- Re: [PATCH 04/14] block: Rename refresh_... Vladimir Sementsov-Ogievskiy
- [PATCH 07/14] block: use bdrv_co_refresh_tota... Kevin Wolf
- Re: [PATCH 07/14] block: use bdrv_co_ref... Vladimir Sementsov-Ogievskiy
- [PATCH 02/14] block: Convert bdrv_io_plug() t... Kevin Wolf
- Re: [PATCH 02/14] block: Convert bdrv_io... Vladimir Sementsov-Ogievskiy
- Re: [PATCH 02/14] block: Convert bdr... Emanuele Giuseppe Esposito
- Re: [PATCH 02/14] block: Convert bdrv_io... Vladimir Sementsov-Ogievskiy
- Re: [PATCH 02/14] block: Convert bdr... Emanuele Giuseppe Esposito
- [PATCH 13/14] block: Convert bdrv_debug_event... Kevin Wolf
- [PATCH 05/14] block: Convert bdrv_refresh_tot... Kevin Wolf
- Re: [PATCH 05/14] block: Convert bdrv_re... Vladimir Sementsov-Ogievskiy
- [PATCH 06/14] block-backend: use bdrv_getleng... Kevin Wolf
- Re: [PATCH 06/14] block-backend: use bdr... Vladimir Sementsov-Ogievskiy
- Re: [PATCH 06/14] block-backend: use... Emanuele Giuseppe Esposito
- Re: [PATCH 00/14] block: Move more functions ... Emanuele Giuseppe Esposito