On 9/1/23 15:18, BALATON Zoltan wrote:
On Mon, 9 Jan 2023, Philippe Mathieu-Daudé wrote:
On 9/1/23 14:33, BALATON Zoltan wrote:
On Mon, 9 Jan 2023, Philippe Mathieu-Daudé wrote:
Use the same property name than the TYPE_PFLASH_CFI01 model.
Nothing uses it? Can this break command lines and if so do we need
deprecation or some compatibility function until everybody changed
their usage?
Good point... I missed that :/
How deprecation works in that case, can I simply add an extra
property with DEFINE_PROP_UINT8()? I'm worried about an user
doing:
-device cfi.pflash02,device-width=4,width=2,...
Or maybe just leave it alone to avoid further problems. Cfi02 only has
width and 4 sector lengths with corresponding sizes, while cfi01 has
width, device-width and max-device-width so these just seem to be
describing geometry differently so maybe no need to try to use same
property names. Width is also shorter than device-width so I'd keep that
for brevity.
I don't mind for this particular model, but I'd like to understand
how to fix this generically, because I have other models to modify...
Back to our pflash models, the multiple '*width' properties are a way
to implement interleaved parallel flashes. For previous discussions
see:
https://lore.kernel.org/qemu-devel/20190426162624.55977-5-stephen.checko...@oberlin.edu/
and a way to unify:
https://lore.kernel.org/qemu-devel/20200817161853.593247-5-f4...@amsat.org/
