Bernhard Beschow <shen...@gmail.com> writes: > Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster <arm...@redhat.com>: >>Bernhard Beschow <shen...@gmail.com> writes: >> >>> When removing the "hw/boards.h" include from >>> hw/acpi/acpi_dev_interface.h, these include directives must be added to make >>> the code compile again. >>> >>> Signed-off-by: Bernhard Beschow <shen...@gmail.com> >> >>You don't actually remove #include "hw/boards.h" from >>hw/acpi/acpi_dev_interface.h in this series. Accident? > > It gets removed in "[PATCH 3/7] hw/acpi/acpi_dev_interface: Resolve > AcpiDeviceIfClass::madt_cpu", no?
Got eaten on the way to me, and I didn't notice, because git-am is still happy. Sorry for the noise! The commit message could point to PATCH 3. However, I'd reshuffle a bit instead. Split PATCH 3 into everything but the removal of #include "hw/boards.h", and the removal. Squash PATCH 1 into the latter, resulting in a straighforward cleanup patch.
