Allowing websockets is fine, but just removing this check is not
> sufficient
>
> The 'websocket=XXXX' parameter for -vnc takes two formats
>
> websocket=on|off
>
> or
>
> websocket=portnum
>
> In the case of on|off, the code takes the original VNC display
> num and listens on 5700 + display for websockets, 590 + display
> for non-websockets.
>
> In the case of a explicit port, the code listens on that port.
>
> Also we fail to actually handle 'off' correctly, just treating
> it as a named port
>
> $ qemu-system-x86_64 -vnc :1,websocket=off
> qemu-system-x86_64: -vnc :1,websocket=off: address resolution failed for
> :off: Servname not supported for ai_socktype
>
>
> Anyway given an argument
>
> -vnc unix:/some/path,websocket=on
>
> this cause causes QEMU to listen on a relative path 'on'. We need
> to define what the semantics for websockets=on are going to be
> for UNIX sockets. Should it append '.ws' to the main path ? Should
> we just not allow websockets=on and document it must be an explicit
> path at all times ?
>
> We also need to document this in qemu-options.hx.
>
>
>
Thank you, these semantics weren't obvious to me, I will adapt accordingly
and post a new patch
