Philippe Mathieu-Daudé <phi...@linaro.org> writes: > On 19/1/23 19:50, Richard Henderson wrote: >> On 1/19/23 03:54, Fabiano Rosas wrote: >>> Move all the CONFIG_FOO=y from default.mak into "default y if TCG" >>> statements in Kconfig. That way they won't be selected when >>> CONFIG_TCG=n. >>> >>> I'm leaving CONFIG_ARM_VIRT in default.mak because it allows us to >>> keep the two default.mak files not empty and keep aarch64-default.mak >>> including arm-default.mak. That way we don't surprise anyone that's >>> used to altering these files. >>> >>> With this change we can start building with --disable-tcg. >>> >>> Signed-off-by: Fabiano Rosas<faro...@suse.de> >>> --- >>> sbsa-ref has an explicit check to avoid running with KVM >>> xlnx-versal-virt has avocado tests tagged with tcg >>> --- >>> configs/devices/aarch64-softmmu/default.mak | 4 -- >>> configs/devices/arm-softmmu/default.mak | 37 ------------------ >>> hw/arm/Kconfig | 42 ++++++++++++++++++++- >>> 3 files changed, 41 insertions(+), 42 deletions(-) >> >> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > The previous version was cleaner IMHO, not restricting only the > machines but also the cores: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg777724.html
I'm not able to apply that thread, there's missing emails in lore. =/ What do you suggest here? I like that you added detailed descriptions of what was being removed and why. But it seems there's a lot left to be restricted still, compared to this patch. I also don't really understand what you mean by "also the cores". This series already moved all cpus under CONFIG_TCG and what's left is only the machines. If there's extra refinement to the configs, we should definitely look into doing it, but I think that could come as a follow-up series.