On Thu, Dec 22, 2022 at 6:29 PM Mauro Matteo Cascella
<mcasc...@redhat.com> wrote:
>
> Local variable "name" is allocated through strdup_printf and should be
> freed with g_free() to avoid memory leak.
>
> Fixes: 3616f424 ("nubus-device: add romfile property for loading declaration 
> ROMs")
> Signed-off-by: Mauro Matteo Cascella <mcasc...@redhat.com>
> ---
>  hw/nubus/nubus-device.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/nubus/nubus-device.c b/hw/nubus/nubus-device.c
> index 0f1852f671..49008e4938 100644
> --- a/hw/nubus/nubus-device.c
> +++ b/hw/nubus/nubus-device.c
> @@ -80,6 +80,7 @@ static void nubus_device_realize(DeviceState *dev, Error 
> **errp)
>                                 &error_abort);
>          ret = load_image_mr(path, &nd->decl_rom);
>          g_free(path);
> +        g_free(name);
>          if (ret < 0) {
>              error_setg(errp, "could not load romfile \"%s\"", nd->romfile);
>              return;
> --
> 2.38.1

Hi, any updates here? Is this patch going to be merged?

Thanks,

--
Mauro Matteo Cascella
Red Hat Product Security
PGP-Key ID: BB3410B0


Reply via email to