Harsh Bora writes:
> On 01/11/2012 11:35 PM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova<vilan...@ac.upc.edu>
>> ---
>> scripts/tracetool.py | 14 +++++++-------
>> 1 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/scripts/tracetool.py b/scripts/tracetool.py
>> index 6874f66..80e5684 100755
>> --- a/scripts/tracetool.py
>> +++ b/scripts/tracetool.py
> [.. snip ..]
>> @@ -510,14 +508,16 @@ class Event(object):
>>
>> # Generator that yields Event objects given a trace-events file object
>> def read_events(fobj):
>> + res = []
>> event_num = 0
>> for line in fobj:
>> if not line.strip():
>> continue
>> if line.lstrip().startswith('#'):
>> continue
>> - yield Event(event_num, line)
>> + res.append(Event(event_num, line))
>> event_num += 1
>> + return res
>>
> Hi Lluis,
> This looks really nice. I can include your fixes while addressing other review
> comments. Shall I fold your patches with mine or do you want to keep them
> separate?
Whatever works best for you.
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
