On Tue, Jan 31, 2023 at 7:23 PM Richard Henderson <richard.hender...@linaro.org> wrote: > > On 1/31/23 08:01, Christoph Muellner wrote: > > + if ((memop & MO_SIZE) == MO_64) { > > + addr2 = get_address(ctx, a->rs, 8 + (a->sh2 << shamt)); > > + } else { > > + addr2 = get_address(ctx, a->rs, 4 + (a->sh2 << shamt)); > > + } > > Use memop_size(memop) instead.
Will be part of v5 (will be sent in a couple of minutes). I have also added a "int imm = a->sh2 << shamt;". > > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Thanks for the review! > > > r~