Thank you for the feedback. I will keep the points in mind next time.

On Wed, 1 Feb 2023, 3:24 pm Alex Bennée, <alex.ben...@linaro.org> wrote:

>
> Khadija Kamran <kkamran.bese16se...@seecs.edu.pk> writes:
>
> > Signed-off-by: Khadija Kamran <kkamran.bese16se...@seecs.edu.pk>
> > ---
> > The Free Software Foundation moved to a new address and this file
> referred to their old location.
> > The address should be updated and replaced to a pointer to <
> https://www.gnu.org/licenses/>
> > This will resolve the issue #379 in the QEMU source repository
>
> For next time I would put this comment in the cover letter. You can also
> add:
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/379
>
> to the commit message to auto close the bug once this is merged.
>
> Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
>
> >
> >  hw/sh4/sh7750_regs.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/hw/sh4/sh7750_regs.h b/hw/sh4/sh7750_regs.h
> > index beb571d5e9..94043431e6 100644
> > --- a/hw/sh4/sh7750_regs.h
> > +++ b/hw/sh4/sh7750_regs.h
> > @@ -22,8 +22,7 @@
> >   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >   * General Public License for more details. You should have received
> >   * a copy of the GNU General Public License along with RTEMS; see
> > - * file COPYING. If not, write to the Free Software Foundation, 675
> > - * Mass Ave, Cambridge, MA 02139, USA.
> > + * file COPYING. If not, see <https://www.gnu.org/licenses/>.
> >   *
> >   * As a special exception, including RTEMS header files in a file,
> >   * instantiating RTEMS generics or templates, or linking other files
>
>
> --
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
>

Reply via email to