On Mon, Feb 06, 2023 at 02:29:49PM +0100, Hanna Czenczek wrote: > g_hash_table_destroy() and g_hash_table_foreach_remove() (called by > curl_drop_all_sockets()) both require the table to be non-NULL, or will > print assertion failures (just print, no abort). > > There are several paths in curl_open() that can lead to the out_noclean > label without s->sockets being allocated, so clean it only if it has > been allocated. > > Example reproducer: > $ qemu-img info -f http '' > qemu-img: GLib: g_hash_table_foreach_remove: assertion 'hash_table != NULL' > failed > qemu-img: GLib: g_hash_table_destroy: assertion 'hash_table != NULL' failed > qemu-img: Could not open '': http curl driver cannot handle the URL '' (does > not start with 'http://') > > Closes: https://gitlab.com/qemu-project/qemu/-/issues/1475 > Suggested-by: Daniel P. Berrangé <berra...@redhat.com> > Signed-off-by: Hanna Czenczek <hre...@redhat.com> > --- > block/curl.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
