Re: [PATCH 04/12] tests/qtest: Skip virtio-serial-console tests if device not present

[Thomas Huth]

On 06/02/2023 16.04, Fabiano Rosas wrote:
The virtconsole device might not be present in the QEMU build that is
being tested. Skip the test if that's the case.
Signed-off-by: Fabiano Rosas <faro...@suse.de>
---
  tests/qtest/virtio-serial-test.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/tests/qtest/virtio-serial-test.c b/tests/qtest/virtio-serial-test.c
index 2541034822..f4e05e8fdd 100644
--- a/tests/qtest/virtio-serial-test.c
+++ b/tests/qtest/virtio-serial-test.c
@@ -28,6 +28,10 @@ static void register_virtio_serial_test(void)
  {
      QOSGraphTestOptions opts = { };
  
+    if (!qtest_has_device("virtconsole")) {
+        return;
+    }

Maybe it makes more sense to check for CONFIG_VIRTIO_SERIAL in the 
meson.build file first?

 Thomas