Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> wrote: > On 08.02.23 16:57, Juan Quintela wrote: >> { >> - uint64_t pend_pre, pend_compat, pend_post; >> + uint64_t pend_pre, pend_post; >> bool in_postcopy = s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE; >> - qemu_savevm_state_pending_estimate(&pend_pre, &pend_compat, >> &pend_post); >> - uint64_t pending_size = pend_pre + pend_compat + pend_post; >> + qemu_savevm_state_pending_estimate(&pend_pre, &pend_post); >> + uint64_t pending_size = pend_pre + pend_post; > > Mixed declarations are "gnerally not allowed" by devel/style.rst.. > Preexisting, but we may fix it now.
They are used left and right. But you are right. Instead to change my code, I have sent a proposal to change devel/style.rst. Discuss it there O:-) > Anyway: > > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> Thanks.