On Fri, 17 Feb 2023 at 20:41, Dinah Baum <dinahbaum...@gmail.com> wrote: > > QEMU configure script goes into an infinite error printing loop > when in read only directory due to 'build' dir never being created. > > Checking if 'mkdir dir' succeeds prevents this error. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/321 > Signed-off-by: Dinah Baum <dinahbaum...@gmail.com> > --- > Changes since v2: > Updated error message > Reverted changes to 'help' command > > configure | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 00415f0b48..784f9d18a5 100755 > --- a/configure > +++ b/configure > @@ -31,7 +31,12 @@ then > fi > fi > > - mkdir build > + if ! mkdir build || ! touch $MARKER > + then > + echo "ERROR: Could not create ./build directory. Check the > permissions on > + your source directory, or try doing an out-of-tree build."
This works, but the second line ends up a bit oddly indented in the output (because the indent in the source file at the start of the second line gets output verbatim). Using a second 'echo' command for the second line is the easiest way to fix that. If you fix that and resend this patch, then you can put Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> in the commit message under your signed-off-by line. thanks -- PMM
