On 24/02/2023 08.38, Philippe Mathieu-Daudé wrote:
Remove a pair of TARGET_X86_64 #ifdef'ry by introducing the win_dump_available() method. Doing so we can build win_dump.c on any target, and simplify the meson rule.
Nit: The commit description is a little bit misleading now since you introduce the #ifdef in win_dump.c instead. Maybe rather something like:
To make dump.c less target dependent, move the TARGET_X86_64 #ifdef'ry from dump.c to win_dump.c (and introduce a win_dump_available() method there). By doing so we can build win_dump.c on any target, and simplify the meson rule.
Anyway, you can keep my Reviewed-by here. Thomas
