Hi, On Mon, Feb 27, 2023, at 1:40 AM, Marc-André Lureau wrote: > Hi > > On Fri, Feb 24, 2023 at 8:31 AM Daniel Xu <d...@dxuuu.xyz> wrote: >> >> This commit adds a test to ensure `merge-output` functions as expected. >> We also add a negative test to ensure we haven't regressed previous >> functionality. >> >> Signed-off-by: Daniel Xu <d...@dxuuu.xyz> > > Please check your patch with ASAN, you have use after-free introduced > by this change: > ==664972==ERROR: AddressSanitizer: heap-use-after-free on address > 0x621000135028 at pc 0x55e617a38b39 bp 0x7fff7fe85390 sp > 0x7fff7fe85388 > READ of size 8 at 0x621000135028 thread T0 > #0 0x55e617a38b38 in qdict_find ../qobject/qdict.c:96 > #1 0x55e617a39bea in qdict_get ../qobject/qdict.c:164 > #2 0x55e617a39bea in qdict_get_int ../qobject/qdict.c:209 > #3 0x55e6179e2519 in test_qga_guest_exec ../tests/unit/test-qga.c:807 > #4 0x7fbaa499dc7d in g_test_run_suite_internal > (/lib64/libglib-2.0.so.0+0x84c7d) > #5 0x7fbaa499d9e4 in g_test_run_suite_internal > (/lib64/libglib-2.0.so.0+0x849e4) > #6 0x7fbaa499e181 in g_test_run_suite (/lib64/libglib-2.0.so.0+0x85181) > #7 0x7fbaa49966ec in g_test_run (/lib64/libglib-2.0.so.0+0x7d6ec) > #8 0x55e6179da0ac in main ../tests/unit/test-qga.c:1083 > #9 0x7fbaa384a50f in __libc_start_call_main (/lib64/libc.so.6+0x2750f) > #10 0x7fbaa384a5c8 in __libc_start_main@GLIBC_2.2.5 > (/lib64/libc.so.6+0x275c8) > #11 0x55e6179daf44 in _start > (/home/elmarco/src/qemu/build/tests/unit/test-qga+0x1bbf44)
Ack. Will fix. [...] Thanks, Daniel
