On Tue, Feb 14, 2023 at 02:14:31PM +0100, Bernhard Beschow wrote:
> Settle on little endian which is consistent with using
> pci_host_conf_le_ops.
>
> Fixes: bafc90bdc594 'q35: implement TSEG'
> Signed-off-by: Bernhard Beschow <shen...@gmail.com>
I think it's native because native is a bit cheaper and
it's just 0xffffffff anyway.
Why change? A comment would be a good idea though.
> ---
> hw/pci-host/q35.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 83f2a98c71..3124cad60f 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -289,7 +289,6 @@ static void blackhole_write(void *opaque, hwaddr addr,
> uint64_t val,
> static const MemoryRegionOps blackhole_ops = {
> .read = blackhole_read,
> .write = blackhole_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> .valid.min_access_size = 1,
> .valid.max_access_size = 4,
> .impl.min_access_size = 4,
> --
> 2.39.1
