On 3/1/23 02:05, Emilio Cota wrote:
As I mentioned in the patch that is being superseded here
I like this approach -- it is simpler and generates less
code.
I'd also like to see the plugin_gen_disable_mem_helpers
function go away, and a mention somewhere that now we are
intentionally not clearing cpu->plugin_mem_cbs until TB exit
(before we weren't doing that either, but that was unintentional
due to a bug). So, for instance when doing a goto_tb from a
TB with helpers, we leave plugin_mem_cbs set.
plugin_mem_cbs is used by all out-of-line load/store, therefore we cannot leave it set
longer than required.
r~
