This series fixes more instances of the problem fixed by commits
5710a3e09f9b ("async: use explicit memory barriers", 2020-04-09) and
7455ff1aa015 ("aio_wait_kick: add missing memory barrier", 2022-06-24).
This is an interesting case where ARM's memory ordering is somewhat
stronger than what you would expect.
On ARM, seqcst loads and stores (which QEMU does not use) are compiled
respectively as LDAR and STLR instructions. Even though LDAR is
also used for load-acquire operations, it also waits for all STLRs to
leave the store buffer. Thus, LDAR and STLR alone are load-acquire
and store-release operations, but LDAR also provides store-against-load
ordering as long as the previous store is a STLR.
Compare this to ARMv7, where store-release is DMB+STR and load-acquire
is LDR+DMB, but an additional DMB is needed between store-seqcst and
load-seqcst (e.g. DMB+STR+DMB+LDR+DMB); or with x86, where MOV provides
load-acquire and store-release semantics and the two can be reordered.
Likewise, on ARM sequentially consistent read-modify-write operations only
need to use LDAXR and STLXR respectively for the load and the store, while
on x86 they need to use the stronger LOCK prefix.
In a strange twist of events, however, the _stronger_ semantics
of the ARM instructions can end up causing bugs on ARM, not on x86.
The problems occur when seqcst atomics are mixed with relaxed atomics.
Here is how the two are compiled on ARM:
load store
relaxed LDR STR
seqcst LDAR STLR
QEMU's atomics try to bridge the Linux API (that most of the developers
are familiar with) and the C11 API, and the two have a substantial
difference:
- in Linux, strongly-ordered atomics such as atomic_add_return() affect
the global ordering of _all_ memory operations, including for example
READ_ONCE()/WRITE_ONCE()
- in C11, sequentially consistent atomics (except for seqcst fences)
only affect the ordering of sequentially consistent operations.
In particular, since relaxed loads are done with LDR on ARM, they are
not ordered against seqcst stores (which are done with STLR).
QEMU implements high-level synchronization primitives with the idea that
the primitives contain the necessary memory barriers, and the callers can
use relaxed atomics (qatomic_read/qatomic_set) or even regular accesses.
This is very much incompatible with the C11 view that seqcst accesses
are only ordered against other seqcst accesses, and requires using
seqcst fences as in the following example:
qatomic_set(&y, 1); qatomic_set(&x, 1);
smp_mb(); smp_mb();
... qatomic_read(&x) ... ... qatomic_read(&y) ...
Bugs ensue when a qatomic_*() read-modify write operation is used instead
of one or both stores, for example:
qatomic_<rmw>(&y, ...);
smp_mb();
... qatomic_read(&x) ...
Code that was written when QEMU used the older GCC __sync_* builtins
(which did provide a full barrier with loads on either side of the
operation) might omit the smp_mb(). That's exactly what yours truly did
in qemu_event_set() and qemu_event_reset(). After a27dd2de68f3 ("KVM:
keep track of running ioctls", 2023-01-11), this showed up as hangs due to
threads sleeping forever in qemu_event_wait().
This _could_ also have been the cause of occasional hangs of rcutorture,
though I have not observed them personally.
In order to fix this, while avoiding worse performance from having two
back-to-back memory barriers on x86, patch 1 introduces optimized
memory barriers smp_mb__before_rmw() and smp_mb__after_rmw(). The usage
is similar to Linux's smp_mb__before/after_atomic(), but the name is
different because they affect _all_ RMW operations. On Linux, instead,
they are not needed around those RMW operations that return the old value.
The compiler does the same when compiling __sync_* atomics, i.e. it adds
an extra memory barrier after the STLXR instruction on ARM but it does
nothing on x86.
The remaining patches add them everywhere they are needed. In the
case of QemuEvent (patches 2-3), I reviewed the algorithm thoroughly,
dropping barriers that were not necessary and killing optimizations that
I wasn't entirely sure about. For the other cases, instead, the changes
are minimal.
Note: I have a follow-up set of patches that gets rid completely of
atomic_mb_read(); atomic_mb_set() instead can remain and mimic Linux's
smp_store_mb() operation. A glimpse of these changes is already visible
in patches 6 and 7.
Thanks to Emanuele Esposito and Gavin Shan for help debugging and
testing the changes!
Paolo
v1->v2:
- fix documentation in patch 1
- do not add barrier to util/async.c, update documentation for the
existing ones
- leave acquire barrier in qemu_event_wait()
Paolo Bonzini (9):
qatomic: add smp_mb__before/after_rmw()
qemu-thread-posix: cleanup, fix, document QemuEvent
qemu-thread-win32: cleanup, fix, document QemuEvent
edu: add smp_mb__after_rmw()
aio-wait: switch to smp_mb__after_rmw()
qemu-coroutine-lock: add smp_mb__after_rmw()
physmem: add missing memory barrier
async: update documentation of the memory barriers
async: clarify usage of barriers in the polling case
docs/devel/atomics.rst | 26 +++++++++---
hw/misc/edu.c | 5 +++
include/block/aio-wait.h | 2 +-
include/qemu/atomic.h | 17 +++++++-
softmmu/physmem.c | 3 ++
util/async.c | 43 ++++++++++++--------
util/qemu-coroutine-lock.c | 9 ++++-
util/qemu-thread-posix.c | 69 ++++++++++++++++++++++----------
util/qemu-thread-win32.c | 82 ++++++++++++++++++++++++++------------
9 files changed, 186 insertions(+), 70 deletions(-)
--
2.39.1
