On 23 January 2012 07:20, Peter A. G. Crosthwaite <peter.crosthwa...@petalogix.com> wrote: > --- a/vl.c > +++ b/vl.c > @@ -233,6 +233,7 @@ int boot_menu; > uint8_t *boot_splash_filedata; > int boot_splash_filedata_size; > uint8_t qemu_extra_params_fw[2]; > +const char *qemu_kerndtb = NULL; > > typedef struct FWBootEntry FWBootEntry; > > @@ -2437,6 +2438,9 @@ int main(int argc, char **argv, char **envp) > case QEMU_OPTION_kernel: > kernel_filename = optarg; > break; > + case QEMU_OPTION_kerndtb: > + qemu_kerndtb = optarg; > + break; > case QEMU_OPTION_append: > kernel_cmdline = optarg; > break;
This is inconsistent with how we handle kernel_filename and initrd_filename (throwing things around via random globals is a pretty nasty interface). I think I like the approach Grant Likely suggested of cleaning up the machine->init function signature so we just pass it a struct instead. Also missing the mollyguard on attempting to use -kernel-dtb but not -kernel (cf the check done for -append and -initrd). -- PMM
