On Mär 29 2023, Philippe Mathieu-Daudé wrote: > On 29/3/23 16:00, Daniel P. Berrangé wrote: >> On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: >>> Do not reverse the order of environment variables in the target environ >>> array relative to the incoming environ order. Some testsuites depend on a >>> specific order, even though it is not defined by any standard. >>> >>> Signed-off-by: Andreas Schwab <sch...@suse.de> >>> --- >>> linux-user/main.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >> bsd-user/main.c appears to have an identical code pattern that >> will need the same fix >> >>> >>> diff --git a/linux-user/main.c b/linux-user/main.c >>> index 4b18461969..dbfd3ee8f1 100644 >>> --- a/linux-user/main.c >>> +++ b/linux-user/main.c >>> @@ -691,7 +691,13 @@ int main(int argc, char **argv, char **envp) >>> envlist = envlist_create(); >>> /* add current environment into the list */ >>> + /* envlist_setenv adds to the front of the list; to preserve environ >>> + order add from back to front */ > > Also, QEMU coding style now requires: > > /* > * this comment form. > */
It's unfortunate that the next comment just below doesn't follow the correct style, so I didn't notice. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."