Hi Joe,

> +static int aspeed_i3c_device_ibi_finish(I3CBus *bus)
> +{
> +    AspeedI3CDevice *s = ASPEED_I3C_DEVICE(bus->qbus.parent);
> +    bool nack_and_disable_hj = ARRAY_FIELD_EX32(s->regs, DEVICE_CTRL,
> +                                                HOT_JOIN_ACK_NACK_CTRL);
> +    if (nack_and_disable_hj || s->ibi_data.send_direct_disec) {
> +        aspeed_i3c_device_send_disec(s);
> +    }

Shouldn't this be conditional on the ibi being a HJ request? With this,
I'm seeing the DISEC happen on *all* IBIs.

Cheers,


Jeremy

Reply via email to