On 4/14/23 18:04, Peter Maydell wrote:
+ /* Check if page table walk is to secure or non-secure PA space. */
+ ptw->out_secure = (is_secure
+ && !(pte_secure
+ ? env->cp15.vstcr_el2 & VSTCR_SW
+ : env->cp15.vtcr_el2 & VTCR_NSW));
+ } else {
+ /* Regime is physical */
+ ptw->out_secure = pte_secure;
Is that last comment really correct? I think it could still be stage1 of 2. That said, the actual code looks correct. Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
