Richard Henderson <richard.hender...@linaro.org> wrote: > On 4/26/23 19:12, Juan Quintela wrote: >> The following changes since commit 9c894df3a37d675652390f7dbbe2f65b7bad7efa: >> migration: Create migrate_max_bandwidth() function (2023-04-24 >> 15:01:47 +0200) >> are available in the Git repository at: >> https://gitlab.com/juan.quintela/qemu.git >> tags/migration-20230426-pull-request >> for you to fetch changes up to >> 7b5cd8ff519e9fe3df6cda65428a6f1aa28a6ced: >> vmstate-static-checker: Recognize "num" field (2023-04-26 >> 19:17:55 +0200) >> ---------------------------------------------------------------- >> Migration Pull request >> Hi >> This PULL request is on top of migration-20230424 already queued by >> Richard. >> It contains: >> - MAINTAINERS: make peter and leo reviewers for migration (juan) >> - Disable postcopy + multifd together. It needs at least to call >> send_sync before it will work. (juan) >> - Improve postcopy error messages (peter) >> - vmstate checker: Compare sizes of arrays correctly (peter) >> - Move more capability functions to options.c (juan) >> Please, apply. > > Build failures: > > https://gitlab.com/qemu-project/qemu/-/jobs/4187732684#L2303
Fixed. Sorry about that. It only fails on hosts that don't support userfaultd() (i.e. non-linux). Will resend. Sorry for the noise. Later, Juan. > > ../migration/postcopy-ram.c:1368:6: error: conflicting types for > 'postcopy_ram_supported_by_host'; have '_Bool(MigrationIncomingState > *)' > 1368 | bool postcopy_ram_supported_by_host(MigrationIncomingState *mis) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ../migration/migration.h:27, > from ../migration/postcopy-ram.c:22: > ../migration/postcopy-ram.h:17:6: note: previous declaration of > 'postcopy_ram_supported_by_host' with type > '_Bool(MigrationIncomingState *, Error **)' > 17 | bool postcopy_ram_supported_by_host(MigrationIncomingState *mis, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > r~
