On Thu, May 04, 2023 at 12:40:12PM +0530, Ani Sinha wrote: > > > > On 04-May-2023, at 12:05 PM, Thomas Huth <th...@redhat.com> wrote: > > > > On 03/05/2023 16.55, Ani Sinha wrote: > >> mformat and xorriso tools are needed by biosbits avocado tests. This > >> patchset > >> adds those two tools in the docker container images. > > > > tests/qtest/cdrom-test.c already uses genisoimage to create ISO images, and > > the containers already have that tool installed. Could you maybe switch the > > biosbits test to use that tool? Or the other way round? ... at least having > > two tools to create ISO images in our containers sounds IMHO excessive. > > The dependency comes from the use of grub-mkrescue in the avocado > test in order to generate the iso with the bios bits enabled grub > and boot off with it. Grub-mkrescue is a bash script that uses > mformat and xorriso.
Where does grub-mkrescue come from ? IIUC, we don't have a dep on the grub package in our dockerfiles. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
