On Fri May 26, 2023 at 10:20 PM AEST, Cédric Le Goater wrote:
> On 8/11/22 10:04, Cédric Le Goater wrote:
> > On 8/11/22 09:54, Nicholas Piggin wrote:
[snip]
> >> +
> >> +#define sbe_cmd_dbg(fmt, ...) do { \
> >> + if (DEBUG_SBE_CMD) { \
> >> + fprintf(stderr, "SBE cmd: %s: " fmt, __func__, ## __VA_ARGS__); \
> >> + } \
> >> +} while (0)
> >
> > Please use trace events instead, with a pnv_sbe_ prefix.
> >
> > Apart from that, LGTM !
> >
> > Reviewed-by: Cédric Le Goater <c...@kaod.org>
>
>
>
>
> This looked like an interesting extension to the baremetal models.
> Did you abandon the idea ? if not, it would be good material for
> QEMU 8.1. Could you resend please ? (with the TOD patches)
Hey Cedric,
Yeah I kind of forgot about these for a while, sorry :( Too much
stuff going on... But by an amazing coincidence I have just started to
look at these again in the past few days, so I should try to get it
merged.
Thanks,
Nick
