On 6/1/2023 7:59 AM, Richard Henderson wrote: > On 5/30/23 01:35, Fei Wu wrote: >> + /* >> + * We want to fetch the stats structure before we start code >> + * generation so we can count interesting things about this >> + * generation. >> + */ >> + if (tb_stats_collection_enabled()) { >> + tb->tb_stats = tb_get_stats(phys_pc, pc, cs_base, flags); > > If cflags & CF_PCREL, then 'pc' should not be cached or matched. > Using 'phys_pc' will suffice, so pass 0 in that case. > OK, tb_get_stats(phys_pc, (cflags & CF_PCREL ? 0 : pc), cs_base, flags);
btw, is it possible to drop 'pc' even w/o CF_PCREL setting in cflags? Two TBs with different 'pc' but same 'phys_pc', are they the same? Thanks, Fei. > > r~