On 11/6/23 12:34, Bernhard Beschow wrote:
i440fx_realize() realizes the PCI device inside the host bridge
(PCII440FXState), but is implemented between i440fx_pcihost_realize() and
i440fx_init() which deal with the host bridge itself (I440FXState). Since we
want to append i440fx_init() to i440fx_pcihost_realize() later let's move
i440fx_realize() out of the way.

Yes, i440fx_foo is is PCI PF#0 (physical function) of the
i440fx_pcihost_foo (host bridge) device. We could rename
i440fx_foo -> i440fx_pf0_foo / i440fx_pcifunc0_foo / i440fx_func0_foo
for clarity.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Signed-off-by: Bernhard Beschow <shen...@gmail.com>
---
  hw/pci-host/i440fx.c | 18 +++++++++---------
  1 file changed, 9 insertions(+), 9 deletions(-)


Reply via email to