Re: [PATCH 11/15] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property

[Bernhard Beschow]

Am 12. Juni 2023 10:31:48 UTC schrieb "Philippe Mathieu-Daudé" 
<phi...@linaro.org>:
>On 11/6/23 12:34, Bernhard Beschow wrote:
>> Introduce the property in anticipation of QOM'ification; Q35 has the same
>> property.
>> 
>> Signed-off-by: Bernhard Beschow <shen...@gmail.com>
>> ---
>>   hw/pci-host/i440fx.c | 14 ++++++++++----
>>   1 file changed, 10 insertions(+), 4 deletions(-)
>
>
>> @@ -51,6 +50,7 @@ struct I440FXState {
>>       /*< public >*/
>>         MemoryRegion *system_memory;
>> +    MemoryRegion *address_space_io;
>
>"io_mem" like the property? (this is not an AddressSpace)

Agreed. I'd name it "io_memory" to be consistent with above attribute.

Best regards,
Bernhard

>
>>       MemoryRegion *pci_address_space;
>
>(pre-existing misleading name)
>
>>       MemoryRegion *ram_memory;
>>       Range pci_hole;
>