On Fri, Feb 10, 2012 at 17:47, Anthony Liguori <aligu...@us.ibm.com> wrote:
> On 02/09/2012 10:02 PM, malc wrote:
>>
>> On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
>>
>>> On 02/09/2012 06:59 PM, Andreas F?rber wrote:
>>>>
>>>> Disable warnings for spaces before opening parenthesis in
>>>> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>>>
>>>
>>> Why audio files are such a special thing?
>>
>>
>> Because they are consistently formatted the way they are.
>
>
> I personally hate the QEMU Coding Style I dislike inconsistency more than
> any particular style.I dislike unclear rules more than inconsistency or coding styles. > So I'm with malc here. I'd be opposed to introducing a new file that > deviated from Coding Style but for the ones that already do, I see no reason > to convert them all at once or make the code deviate from the style it's > already using. I'd make a rule, specify the level of importance and try to stick to it. I would not oppose global reformatting to GNU style even (which I hate) if that would be the rule. I don't like laissez faire, but if that is the rule then fine. > >> >>> Isn't it be better to revert a patch that introduced checkpatch.pl >>> errors? >> >> >> No. > > > Regards, > > Anthony Liguori > > >> >
