Hello,
Philippe Mathieu-Daudé <phi...@linaro.org> writes: > On 21/6/23 11:39, Philippe Mathieu-Daudé wrote: >> On 21/6/23 07:19, Richard Henderson wrote: >>> On 6/20/23 19:57, Peter Maydell wrote: >>>> This manifests specifically in 'make check-tcg' failing, because code >>>> in cpus-common.c that sets up the CPUState::cpu_index field puts it >>>> at a different offset from the code in plugins/core.c in >>>> qemu_plugin_vcpu_init_hook() which reads the cpu_index field. The >>>> latter then hits an assert because from its point of view every >>>> thread has a 0 cpu_index. There might be other weird behaviour too. >> Why isn't this covered by CI, and where could we add a such check? > > Actually it is covered and failed on staging: > https://gitlab.com/qemu-project/qemu/-/jobs/4503766933 Just for the record, it was also caught yesterday by the TCWG CI: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-bisect/87/ -- Thiago
