On 13/06/23 10:58 am, Het Gala wrote:
On 06/06/23 3:45 pm, Het Gala wrote:
This patch introduces well defined MigrateAddress struct and its related
child objects.
The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri'
is of string type. The current migration flow follows double encoding
scheme for fetching migration parameters such as 'uri' and this is
not an ideal design.
Motive for intoducing struct level design is to prevent double encoding
of QAPI arguments, as Qemu should be able to directly use the QAPI
arguments without any level of encoding.
Suggested-by: Aravind Retnakaran <aravind.retnaka...@nutanix.com>
Signed-off-by: Het Gala <het.g...@nutanix.com>
Reviewed-by: Juan Quintela <quint...@redhat.com>
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
---
qapi/migration.json | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/qapi/migration.json b/qapi/migration.json
index 179af0c4d8..e61d25eba2 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1407,6 +1407,51 @@
##
{ 'command': 'migrate-continue', 'data': {'state':
'MigrationStatus'} }
+##
+##
+# @MigrationAddress:
+#
+# Migration endpoint configuration.
+#
+# Since 8.1
+##
+{ 'union': 'MigrationAddress',
+ 'base': { 'transport' : 'MigrationAddressType'},
+ 'discriminator': 'transport',
+ 'data': {
+ 'socket': 'SocketAddress',
+ 'exec': 'MigrationExecCommand',
+ 'rdma': 'InetSocketAddress' } }
+
##
# @migrate:
#
Hi maintainers, this is just a reminder mail for v6 patchset for
modification the QAPI design for migration qapis - 'migrate' and
'incoming-migrate'. From the last discussion, I have modified
definitions specifically around QAPIs in patch 1 and 6, and have tried
to make it short and consice and meaningful. Please have a look at it
and suggest if any changes required. Tagging maintainers who have
actively participated in the discussion in last few iterations :
Markus, Daniel, Eric, Juan - but regardless other maintainers are also
very well welcomed to share their opinions.
This is just a friendly reminder mail for v6 patchset discusiion for
modification of QAPI design for migration qapis. I know the maintainers
were quite busy with KVM forum during the time I had sent out first
reminder. Hope to get some positive reviews on the v6 patches soon.
Thanks in advance !!
Regards,
Het Gala
