Re: [PATCH v1 2/2] xen_arm: Initialize RAM and add hi/low memory regions

[Vikram Garhwal]

HI Leo,

On 7/2/23 11:14 PM, Leo Yan wrote:

Hi Vikram,

On Thu, Jun 29, 2023 at 10:43:10AM -0700, Oleksandr Tyshchenko wrote:

[...]

  void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
  {
      hw_error("Invalid ioreq type 0x%x\n", req->type);
@@ -135,6 +170,14 @@ static void xen_arm_init(MachineState *machine)

xam->state = g_new0(XenIOState, 1); + if (machine->ram_size == 0) {

+        DPRINTF("ram_size not specified. QEMU machine will be started without"
+                " TPM, IOREQ and Virtio-MMIO backends\n");
+        return;
+    }
+
+    xen_init_ram(machine);
+
      xen_register_ioreq(xam->state, machine->smp.cpus, xen_memory_listener);

xen_create_virtio_mmio_devices(xam);

@@ -182,6 +225,8 @@ static void xen_arm_machine_class_init(ObjectClass *oc, 
void *data)
      mc->init = xen_arm_init;
      mc->max_cpus = 1;
      mc->default_machine_opts = "accel=xen";
+    /* Set explicitly here to make sure that real ram_size is passed */
+    mc->default_ram_size = 0;

This patch fails to apply on my side on QEMU 8.0.0.

      printf("CHECK for NEW BUILD\n");

The printf sentence is introduced unexpectly, right?

I will rebase it with latest and resend v2.
Thank you!

Thanks,
Leo

  #ifdef CONFIG_TPM
--
2.25.1