On Mon, 17 Jul 2023 at 22:36, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > We already evaluated directory_shift and leaf_shift in > page_table_walk_refill(), no need to do that again: pass > as argument. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > --- > target/mips/tcg/sysemu/tlb_helper.c | 18 ++++++++----------
Yeah, this is definitely better. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM