Quoting Daniel P. Berrangé (2023-07-26 04:18:37)
> On Wed, Jul 26, 2023 at 12:05:41PM +0300, Michael Tokarev wrote:
> > 26.07.2023 11:50, Daniel P. Berrangé wrote:
> > ..
> > > > make-release.sh apparently does the right thing. But the published
> > > > tarball does not include the 3 required sub-projects anyway.
> > > > 
> > > > Is it about how the release is made?  What is used to make the
> > > > actual release tarball, is it not make-release.sh?
> > > 
> > > make-release is what I expect to be used for making release
> > > tarballs.
> > 
> > When I run ./scripts/make-release 8.1.0-rc1 , the resulting tarball
> > includes the necessary submodules in subprojects/.
> > 
> > It is more: it includes 2 copies of berkeley-softfloat & berkeley-testfloat,
> > one in subprojects/ and one in roms/edk2/ArmPkg/Library/ArmSoftFloatLib/ .
> > 
> > But the tarballs published on qemu.org does not include these.
> > 
> > So I conclude the tarballs were not created using make-release.sh.
> 
> I filed an issue for this and marked it as a release blocker.
> 
>   https://gitlab.com/qemu-project/qemu/-/issues/1791
> 
> rc0 was broken in the same way too.

Sorry for the breakage. I've updated the issue with the resolution and
re-uploaded fixed QEMU 8.1.0-rc1 tarballs to qemu.org.

I also hit a secondary issue where the new meson-wrapped subprojects now
require meson >= 0.55 when generating tarballs (since make-release doesn't
make use of the newer one provided locally by QEMU). Upgrading from Ubuntu
20.04 to 22.04 fixed this for me.

Hopefully things are good now.

-Mike

> 
> With regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>

Reply via email to