05.08.2023 12:28, Hawkins Jiawei wrote:
..
I don't remember why, but this patch series is marked as "check later" in
my qemu-stable-to-apply email folder. Does it make sense to back-port this
series to stable-8.0?
6f34807116 vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in
_load_offloads()
f45fd95ec9 vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in _load_mq()
b479bc3c9d vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in _load_mac()
Hi Michael,
Yes, this bug exists in stable-8.0, so it makes sense to back-port this
series.
Commit f45fd95ec9("vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in
_load_mq()") and
commit b479bc3c9d("vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in
_load_mac()") can be back-ported directly.
Patch 6f34807116 also needs
b58d3686a0 vdpa: Add vhost_vdpa_net_load_offloads()
As you point out, patch 6f34807116("vdpa: Return -EIO if device ack is
VIRTIO_NET_ERR in _load_offloads()") is a fix to the commit
b58d3686a0("vdpa: Add vhost_vdpa_net_load_offloads()"), which was
introduced by patch series "Vhost-vdpa Shadow Virtqueue Offloads
support" at [1].
This mentioned patch series introduces a new feature for QEMU and
has not been merged into stable-8.0 yet, so I think we do not need to
apply the
patch 6f34807116("vdpa: Return -EIO if device ack is
VIRTIO_NET_ERR in _load_offloads()") to stable-8.0.
Ok, this makes sense, thank you for making it clear.
Sorry for not mentioning this information in the cover letter.
That's okay. I too didn't pick it up in time, so fixing this now :
/mjt
