On Mon, 2023-08-07 at 19:00 +0200, David Hildenbrand wrote: > On 07.08.23 18:34, Ilya Leoshkevich wrote: > > Unlike most other instructions that contain an immediate element > > index, > > VREP's one is 16-bit, and not 4-bit. The code uses only 8 bits, so > > using, e.g., 0x101 does not lead to a specification exception. > > > > Fix by checking all 16 bits. > > > > Cc: qemu-sta...@nongnu.org > > Just curious, why stable? Are there valid programs that set invalid > element size and they are fixed by this?
None that I know of, but I thought this was still nice to have, and at the same time small enough to not cause any trouble. > LGTM > > Reviewed-by: David Hildenbrand <da...@redhat.com> [...] >