Am 21.02.2012 09:35, schrieb Paolo Bonzini: > On 02/20/2012 11:50 AM, Alexander Graf wrote: >>>> DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); >>>> >>>> - trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); >>>> + trace_dma_bdrv_io(dbs, bs, sector_num, dir); >> Was the trace wrong before or is it now? I don't see its definition changed >> anywhere. > > Not sure what you mean. :)
trace-events: dma_bdrv_io(void *dbs, void *bs, int64_t sector_num, bool to_dev) "dbs=%p bs=%p sector_num=%" PRId64 " to_dev=%d" to_dev is declared bool here, and it should also be renamed to dir (the unfortunate thing about DMADirection is that it swaps 0 and 1 compared to bool to_dev... We need to check carefully that all occurrences have been caught.) Kevin
