On 30/08/2023 11.37, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau <marcandre.lur...@redhat.com>
Hi,
QEMU system emulators can be made to compile and work without pixman.
Given how pervasively pixman types and API is used in all the code base, it was
a bit difficult to figure out how to cut the dependency.
I decided that it was important to keep VGA and graphics device working for
compatibility reasons, although some devices, such as xlnx Display Port, have
stronger dependency and have to be disabled. The ui/console code also has a lot
of pixman usage and a bit of a mess to deal with. I made large refactoring to
allow to compile out the VC code.
The series can be roughly divded as:
- a few related preliminary cleanups
- ui/console refactoring to allow ui/vc split
- add a 'pixman' option, and a minimal pixman-compat.h
- make some parts depend on 'pixman'
Graphic -display still work, although with some caveats. For ex, -display sdl or
cocoa don't have VCs, so starting QEMU will print the following warnings when
pixman is disabled:
I just had a quick look at the series, but for me it looks like this is
adding a lot of additional complexity to the code (adds lots of #ifdefs, and
adds a subset of the pixman library to the code base), which seems somewhat
unfortunate for such a marginal feature request. What's really so bad about
requiring pixman for building QEMU?
IMHO, if we really want to go down this path, I think we should rather
disable all graphic related stuff in QEMU instead, i.e. disable VGA cards,
Spice, SDL, etc. completely. I think this is also what has been requested in
the original gitlab issue ticket where the reporter wanted to compile a
text-mode only QEMU binary...?
... just my 0.02 € anyway.
Thomas
